Greased Lightbox v0.14 by Joe Lencioni

12 Comments

1. Muescha said
   July 25th, 2006 at 10:07 am

   here my feedback and my suggestions.

   the most wanted feature is for me is a “debug modus”.

   1) maka a Debug mode
   ===================

   1a) make a userinterface for to define new sites to lightbox
   1b) make a small debug-modus (not every user is very firm in regular expressions, and if i not see the target links and the result links it ist not very easy to make the best regular expressions)

   Debug-Information in a debug-window
   -> list each link
   —> found searchDefs.name
   ——> show test with searchDefs regex
   ——> show result of searchDefs regex
   ——> show result of searchDefs replaceString

   Debug-Information as a hoover tooltip over a link
   –> add to a link or a picture the result of each test as a tooltip

   1c) if you make a extension from this script: you can make a sidebar like “adblock plus” and the sidebar with a list of all links effectect

   2) Exchange page definitions
   =====================

   2a) save the page-definition away from the script
   2b) make a page-definition repository at a webpage, so that users can exchange the page-definitions (post definition / load definition from webpage)

   3) mark lightbox links
   ==============

   3a) with a special border or a small icon
   3b) or mark it if im hover over the link

   43) disable Lightbox
   ===================

   4a) temporable disable the lightbox klick with a key-mouse-shortcut (example disable it, if hold the shift key during the mouseclick)
   4b) disable this site with lightbox
   4c) rightmenu: add this site to excluded sites

2. eXtreme said
   July 26th, 2006 at 9:54 am

   Greased Lightbox doesn’t work with image set in Lightbox JS v2.0 (http://www.huddletogether.com/projects/lightbox2/)
   Greased Lightbox finds only rel=”lightbox” but doesn’t find rel=”lightbox[foo]”

   How to fix this bug?
   Go to line 367 and replace:

   if (link.getAttribute(’rel’) == ‘lightbox’) return true;

   with:

   var relAttribute = String(link.getAttribute(’rel’));
   if (relAttribute.toLowerCase().match(’lightbox’)) return true;

3. (post author) Joe Lencioni said
   July 26th, 2006 at 10:21 am

   Thanks guys for your feedback.

   @eXtreme: I will incorporate this into the next version. Thanks!

4.  

5. eXtreme said
   July 26th, 2006 at 11:05 am

   OK I have also an bug with GS in Opera (9).

   Watch this video: http://video.google.com/videoplay?docid=-5088756032932447070 (choose “Original size” in player - image has been scaled down by google :/)
   Sometimes Greased Lightbox loads image but later it can’t do this.

   Cache in my Opera is totally disabled - maybe this is the cause of the bug. I had enabled cache but… it hasn’t seem to be working. :P

   PS. Sorry for mistakes, my english isn’t good. ;)

6. Stoen said
   July 28th, 2006 at 9:05 pm

   The lines of code where you insert elements into the page are bugged
   For instance line 848:
   objBody.insertBefore(objMenu, objBody.nextSibling);
   There would be no problem when BODY is the last child of HTML and so objBody.nextSibling is null and your insertBefore statement just behaves like appendChild. But what happens when objBody.nextSibling is not null? You are trying to insert elements into BODY at a position in the DOM that exists outside of BODY

7. paul irish said
   November 9th, 2006 at 11:39 pm

   probably the best greasemonkey script ever.
   yeah.. yeah i think so.

   cheers.

8. (post author) Joe Lencioni said
   November 9th, 2006 at 11:42 pm

   thanks paul!

9. Peter said
   March 1st, 2007 at 12:52 pm

   really really great script. fantastic job.

   one thing– it clobbers lots of other scripts. how can this be dealt with? i’m not sure when greasemonkey runs in the order of things, but if it is given a lower priority, you could just ignore images that already had javascript assignments attached to them? it would be nice if there was atleast the option to be more passive.

10. Peter said
    March 1st, 2007 at 1:52 pm

    Also, there should be a link to view the image without the lightbox interface. Perhaps you should link the text beneath the image (and force a default) to the original image location.

11. Peter said
    March 1st, 2007 at 1:56 pm

    last thing, sorry. a button to zoom to original size and an indication that image is not fully zoomed is very important.

12. (post author) Joe Lencioni said
    March 1st, 2007 at 2:09 pm

    @ Peter - thanks for all of the suggestions. I’ll look into these things.

13. grasshipper said
    April 21st, 2007 at 5:01 am

    i was wondering, is there an easy way for other gm scripts that generate thumbnails on pages to include the lightbox functionality from the greased lightbox script, maybe make a global function available via “unsafeWindow” that can be added to the thumbnails somehow

Leave a Comment